Removed deferred call to Wipe on decoding creds #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible to call wipe after the contents are processed.
aricart
requested review from
sasbury and
kozlovic
and removed request for
sasbury
kozlovic
requested changes
Aug 2, 2019
There was a problem hiding this comment.
At this point, the NATS Go client is no longer doing a wipe.. so I would recommend either:
- Change the NATS Go client to do the wipe
- Do the wipe in ParseDecoratedX() but then caller needs to make copy of passed content if it needs to use it after call to ParseDecoratedX().
Looping @derekcollison.
|
Yes the lib is not loading the bytes, so the wipe cannot happen on a parameter, it must happen on the caller. |
|
I would agree with that. Was just pointing out that NATS Go may have assumed that it was done in the lib (because it was) and removed the wipe calls, which could be put back. Let's wait for @derekcollison to chime in. |
|
Looking at the way wipe was used in the jwt lib I agree it should not be there. We should add back into the Go client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client is responsible to call wipe after the contents are processed.